Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

310 write content for how to run access om #442

Merged
merged 17 commits into from
Jul 20, 2023
Merged

310 write content for how to run access om #442

merged 17 commits into from
Jul 20, 2023

Conversation

atteggiani
Copy link
Contributor

@atteggiani atteggiani commented Jul 17, 2023 •
edited
Loading

  • Wrote content on how to run ACCESS-OM ("output" paragraph still to revise)
  • Some improvements to all "how to run ..." pages
  • Restructured "fontello" and "fontawesome" icons folders. It doesn't change anything in the markdown files/codes, but now all respective files are kept in the respective folders docs/fontello and docs/fontawesome-free-6.4.0-web while changing the mkdocs.yaml file to load css files needed for the icons. This keeps the docs/css folder cleaner and makes it easier to add new "fontello" icons to the available icons pack.
    This is the reason why you see so many files changed (that's mostly the files inside fontawesome-free-6.4.0-web that got moved).
  • Added icons for external links

@atteggiani
Copy link
Contributor Author

@KAUR1984 @svenbuder
Can you please check if you like the rendering of external link icons?

A part of me likes them, but a part of me thinks there is something that might be improved.
Thank you!

@github-actions
Copy link

github-actions bot commented Jul 17, 2023 •
edited
Loading

PR Preview Action v2.1.1
🛬 Preview removed because the pull request was closed.
2023-07-20 01:28 UTC

@KAUR1984
Copy link
Contributor

Thanks for these changes @atteggiani ! These icons are already looking great to me and are really informative overall on the hive for showing external websites links.

Just a thought on the vertical alignment of the icon - do these icons look better if aligned at the top (as in the current implementation) or could we possibly try vertically centering them?

Otherwise, I am very happy with the current implementation :)

@KAUR1984
Copy link
Contributor

Whoops, I think we got some conflicts with the changes made in the latest pr - #443 (comment).

@atteggiani
Copy link
Contributor Author

Whoops, I think we got some conflicts with the changes made in the latest pr - #443 (comment).

Solved it, pulled the latest development branch and merged with this branch (#310).

@atteggiani atteggiani mentioned this pull request Jul 17, 2023
Closed
1 task
@atteggiani
Copy link
Contributor Author

Thanks for these changes @atteggiani ! These icons are already looking great to me and are really informative overall on the hive for showing external websites links.

Just a thought on the vertical alignment of the icon - do these icons look better if aligned at the top (as in the current implementation) or could we possibly try vertically centering them?

Otherwise, I am very happy with the current implementation :)

I tried rendering them vertically centered, but I personally don't like them. To me it gives them a bit too much importance.

@atteggiani atteggiani merged commit e6b71fe into development Jul 20, 2023
2 checks passed
@atteggiani atteggiani deleted the 310-write-content-for-how-to-run-access-om branch July 20, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen Awaiting requested review from aidanheerdegen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atteggiani @KAUR1984